Skip to content

DOC-1105 RPCN on GCP BYOVPC#238

Merged
asimms41 merged 16 commits intomainfrom
DOC-1105_GCP_on_BYOVPC
Apr 4, 2025
Merged

DOC-1105 RPCN on GCP BYOVPC#238
asimms41 merged 16 commits intomainfrom
DOC-1105_GCP_on_BYOVPC

Conversation

@asimms41
Copy link
Copy Markdown
Contributor

@asimms41 asimms41 commented Mar 20, 2025

Description

Resolves DOC-1105
Review deadline: 2nd April

This pull request introduces several updates to the documentation to support Redpanda Connect for BYOVPC clusters on GCP. The changes include adding new guides, updating prerequisites, and modifying feature availability messages.

This pull request includes several changes to documentation files to update the availability and configuration of Redpanda Connect on BYOVPC clusters, particularly for GCP. The most important changes include adding a new guide for enabling Redpanda Connect on BYOVPC clusters on GCP, updating availability messages, and modifying existing documentation to reflect these updates.

Documentation Updates:

New Guide:

Configuration Instructions:

Availability Message Update:

Page previews

Create BYOVPC on GCP

Enable Redpanda Connect on a BYOVPC Cluster on GCP

Redpanda Connect Quickstart

Cloud Overview

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@hyperlint-ai-deprecated
Copy link
Copy Markdown
Contributor

hyperlint-ai-deprecated bot commented Mar 20, 2025

PR Change Summary

Enhanced documentation for Redpanda Connect on GCP BYOVPC, including service account creation and configuration steps.

  • Added instructions for creating Redpanda Connect service accounts and roles.
  • Included steps to enable Redpanda Connect on existing BYOVPC clusters.
  • Updated commands for managing IAM policy bindings for service accounts.

Modified Files

  • modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
  • modules/networking/pages/gcp-private-service-connect.adoc

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/67efe988ea4a3e1bbc6173e5
😎 Deploy Preview https://deploy-preview-238--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asimms41 asimms41 requested a review from tomasz-sadura March 20, 2025 18:22
@asimms41 asimms41 requested a review from tomasz-sadura March 24, 2025 09:22
Copy link
Copy Markdown
Contributor

@tomasz-sadura tomasz-sadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@asimms41 asimms41 requested a review from tomasz-sadura March 25, 2025 10:44
Copy link
Copy Markdown
Contributor

@tomasz-sadura tomasz-sadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asimms41 asimms41 marked this pull request as ready for review March 25, 2025 11:03
@asimms41 asimms41 requested a review from a team as a code owner March 25, 2025 11:03
@asimms41 asimms41 requested a review from jrkinley March 25, 2025 11:03
@asimms41 asimms41 requested a review from david-yu March 26, 2025 09:07
@david-yu
Copy link
Copy Markdown
Contributor

david-yu commented Mar 28, 2025

Still testing the changes here, I have some feedback on BYOVPC in general for docs which we can probably incorporate the entire process seems pretty onerous to the user.

Btw for the Enable RP Connect docs page, is this only for folks that have existing clusters without RP Connect? Also would we ever want to allow folks to disable RP Connect? @tomasz-sadura

@tomasz-sadura
Copy link
Copy Markdown
Contributor

Having scaling from 0 I don't think it will be the case, unless we want to.

@asimms41 asimms41 requested a review from jrkinley March 28, 2025 10:30
@david-yu
Copy link
Copy Markdown
Contributor

@tomasz-sadura

Having scaling from 0 I don't think it will be the case, unless we want to.

I ask because steps one and two are pretty much the same as what's already included in the create BYOVPC cluster as it is for enable connect: https://deploy-preview-238--rp-cloud.netlify.app/redpanda-cloud/get-started/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp/.

Do folks need to enable connect or does cloud enable it for you if you have the SA and bindings already set?

Also to clarify it sounds like turning off Connect is not an option?

@david-yu
Copy link
Copy Markdown
Contributor

david-yu commented Mar 29, 2025

Ok just re-read it does look like the second page is to enable RP Connect on an existing cluster. Dis-regard question related to existing versus new clusters.

To enable Redpanda Connect on an existing BYOVPC cluster, you must update your configuration. You can also create a new BYOVPC cluster with Redpanda Connect already enabled.

Copy link
Copy Markdown
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but would be good to accept the suggestion as the IP addr is wrong and should be 172.16.0.32/28

Copy link
Copy Markdown
Contributor

@JakeSCahill JakeSCahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice additions 😄

@asimms41 asimms41 requested a review from micheleRP April 4, 2025 13:47
@asimms41 asimms41 merged commit f3c0a5a into main Apr 4, 2025
7 checks passed
@asimms41 asimms41 deleted the DOC-1105_GCP_on_BYOVPC branch April 4, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants