Conversation
PR Change SummaryEnhanced documentation for Redpanda Connect on GCP BYOVPC, including service account creation and configuration steps.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Outdated
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Show resolved
Hide resolved
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Show resolved
Hide resolved
|
Still testing the changes here, I have some feedback on BYOVPC in general for docs which we can probably incorporate the entire process seems pretty onerous to the user. Btw for the Enable RP Connect docs page, is this only for folks that have existing clusters without RP Connect? Also would we ever want to allow folks to disable RP Connect? @tomasz-sadura |
|
Having scaling from 0 I don't think it will be the case, unless we want to. |
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc
Show resolved
Hide resolved
I ask because steps one and two are pretty much the same as what's already included in the create BYOVPC cluster as it is for enable connect: https://deploy-preview-238--rp-cloud.netlify.app/redpanda-cloud/get-started/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp/. Do folks need to enable connect or does cloud enable it for you if you have the SA and bindings already set? Also to clarify it sounds like turning off Connect is not an option? |
|
Ok just re-read it does look like the second page is to enable RP Connect on an existing cluster. Dis-regard question related to existing versus new clusters.
|
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc
Outdated
Show resolved
Hide resolved
david-yu
left a comment
There was a problem hiding this comment.
Approved, but would be good to accept the suggestion as the IP addr is wrong and should be 172.16.0.32/28
JakeSCahill
left a comment
There was a problem hiding this comment.
LGTM. Nice additions 😄
Description
Resolves DOC-1105
Review deadline: 2nd April
This pull request introduces several updates to the documentation to support Redpanda Connect for BYOVPC clusters on GCP. The changes include adding new guides, updating prerequisites, and modifying feature availability messages.
This pull request includes several changes to documentation files to update the availability and configuration of Redpanda Connect on BYOVPC clusters, particularly for GCP. The most important changes include adding a new guide for enabling Redpanda Connect on BYOVPC clusters on GCP, updating availability messages, and modifying existing documentation to reflect these updates.
Documentation Updates:
modules/ROOT/nav.adoc: Added a new link to the guide for enabling Redpanda Connect on BYOVPC clusters on GCP.modules/develop/partials/availability-message.adoc: Updated the availability message to indicate that Redpanda Connect is in beta for BYOVPC clusters on GCP but not available on AWS or Azure.modules/get-started/pages/cloud-overview.adoc: Updated the list of features in limited availability and beta to include Redpanda Connect for BYOVPC on GCP. [1] [2]New Guide:
modules/get-started/pages/cluster-types/byoc/gcp/enable-rpcn-byovpc-gcp.adoc: Added a comprehensive guide for enabling Redpanda Connect on an existing BYOVPC cluster on GCP, including steps to create service accounts, bind them, and update the cluster configuration.Configuration Instructions:
modules/get-started/pages/cluster-types/byoc/gcp/vpc-byo-gcp.adoc: Added detailed instructions for creating and binding service accounts required for Redpanda Connect, and updated the guide to include new permissions and configuration steps. [1] [2] [3] [4] [5] [6] [7] [8] [9]Availability Message Update:
modules/shared/partials/feature-flag-rpcn.adoc: Updated the feature flag message to reflect the beta availability of Redpanda Connect for BYOVPC clusters on GCP.Page previews
Create BYOVPC on GCP
Enable Redpanda Connect on a BYOVPC Cluster on GCP
Redpanda Connect Quickstart
Cloud Overview
Checks